search

linux-system-roles / certificate

Role for managing TLS/SSL certificate issuance and renewal
https://linux-system-roles.github.io/certificate/
MIT License
30 stars 21 forks source link

docs(changelog): version 1.3.4 [citest skip] #222

Closed spetrosi closed 6 months ago

spetrosi commented 6 months ago

Update changelog and .README.html for version 1.3.4

Signed-off-by: Sergei Petrosian spetrosi@redhat.com

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 32.95%. Comparing base (33bac79) to head (a6b6e35).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #222 +/- ## ======================================= Coverage 32.95% 32.95% ======================================= Files 3 3 Lines 613 613 Branches 128 128 ======================================= Hits 202 202 Misses 411 411 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/certificate/pull/222/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/certificate/pull/222/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `32.95% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rjeffman commented 6 months ago

Only now I saw that ansible-lint was bumped to version 24. In ansible-freeipa we found that this version is "hit and miss" and was unstable. Is it required to use version 24 right now?

richm commented 6 months ago

Only now I saw that ansible-lint was bumped to version 24. In ansible-freeipa we found that this version is "hit and miss" and was unstable. Is it required to use version 24 right now?

We generally use whatever version Galaxy and Automation Hub use for gating, and right now that is 24. What issues are you seeing?

rjeffman commented 6 months ago

There were lots of failures on it creating the virtual environment.

We also (try to) use the same version as Galaxy and Automation Hub, and if it is using 24, I'll update it there.

richm commented 6 months ago

There were lots of failures on it creating the virtual environment.

ansible-lint, or ansible-test?

We also (try to) use the same version as Galaxy and Automation Hub, and if it is using 24, I'll update it there.

rjeffman commented 6 months ago

ok... I found out the issue with ansible-lint, and it was on ansible-freeipa. It is fixed now.