linux-system-roles / cockpit

https://linux-system-roles.github.io/cockpit/
GNU General Public License v3.0
18 stars 19 forks source link

fix: add support for EL10 #163

Closed richm closed 4 months ago

richm commented 4 months ago

According to the Ansible team, support for listing platforms in role meta/main.yml files is being removed. Instead, they recommend using galaxy_tags

https://github.com/ansible/ansible/blob/stable-2.17/changelogs/CHANGELOG-v2.17.rst "Remove the galaxy_info field platforms from the role templates" https://github.com/ansible/ansible/issues/82453

Many roles already have tags such as "rhel", "redhat", "centos", and "fedora". I propose that we ensure all of the system roles have these tags. Some of our roles support Suse, Debian, Ubuntu, and others. We should add tags for those e.g. the ssh role already has tags for "debian" and "ubuntu".

In addition - for each version listed under platforms.EL - add a tag like elN.

Q: Why not use a delimiter between the platform and the version e.g. el-10?

This is not allowed by ansible-lint:

meta-no-tags: Tags must contain lowercase letters and digits only., invalid: 'el-10'
meta/main.yml:1

So we cannot use uppercase letters either.

Q: Why not use our own meta/main.yml field?

No other fields are allowed by ansible-lint:

syntax-check[specific]: 'myfield' is not a valid attribute for a RoleMetadata

Q: Why not use some other field?

There are no other applicable or suitable fields.

Q: What happens when we want to support versions like N.M?

Use the word "dot" instead of "." e.g. el10dot3. Similarly - use "dash" instead of "-".

We do not need tags such as fedoraall. The fedora tag implies that the role works on all supported versions of fedora. Otherwise, use tags such as fedora40 if the role only supports specific versions.

In addition - for roles that have different variable files for EL9, create the corresponding EL10 files.

Signed-off-by: Rich Megginson rmeggins@redhat.com