Closed Tronde closed 1 year ago
one minor nit, otherwise, lgtm
Totals | |
---|---|
Change from base Build 3569035399: | 0.0% |
Covered Lines: | 417 |
Relevant Lines: | 788 |
Totals | |
---|---|
Change from base Build 3569035399: | 0.0% |
Covered Lines: | 417 |
Relevant Lines: | 788 |
Thanks for checking the PR. I fixed the name of the task in example/disable-cockpit-and-dhcpv6-client.yml
as well as a yamllint
error found by the tox check.
Sorry, I missed that second issue with the missing space. I'll do better next time by trying to use the tools at hand in a proper way. As far as I could see I hope to have catched all yamllint issues and tox shoudn't find any others. Thanks for your patience.
Sorry, I missed that second issue with the missing space. I'll do better next time by trying to use the tools at hand in a proper way. As far as I could see I hope to have catched all yamllint issues and tox shoudn't find any others. Thanks for your patience.
Thank you for the PR!
IMHO it's useful to have some example playbooks for common use cases that are easy to adapt by copy, paste, and modify.
I like it when roles have an example direktory with some playbooks in it, because it saves time when I don't have to search a long README.md for some examples.
With this PR I would like to contribute some example playbooks for the firewall role. I chose some use cases I encountered in different enviroments.
Signed-off-by: Joerg Kastning jkastning@my-it-brain.de