linux-system-roles / firewall

Configure firewalld and system-config-firewall
https://linux-system-roles.github.io/firewall/
GNU General Public License v2.0
57 stars 32 forks source link

cannot use distutils; use custom version #120

Closed richm closed 1 year ago

richm commented 1 year ago

distutils is deprecated, and ansible-lint 2.14 throws an error about this. There isn't really a suitable version parser replacement that works without additional dependencies across python 2.7 - 3.11. So, write our own version parser.

richm commented 1 year ago

[citest]

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3964247832

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Files with Coverage Reduction New Missed Lines %
/home/runner/work/firewall/firewall/library/firewall_lib.py 132 62.87%
<!-- Total: 132 -->
Totals Coverage Status
Change from base Build 3953356213: 0.5%
Covered Lines: 425
Relevant Lines: 796

💛 - Coveralls
coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3964034200


Files with Coverage Reduction New Missed Lines %
/home/runner/work/firewall/firewall/library/firewall_lib.py 128 62.92%
<!-- Total: 128 -->
Totals Coverage Status
Change from base Build 3953356213: 0.5%
Covered Lines: 426
Relevant Lines: 797

💛 - Coveralls
richm commented 1 year ago

[citest]