linux-system-roles / firewall

Configure firewalld and system-config-firewall
https://linux-system-roles.github.io/firewall/
GNU General Public License v2.0
57 stars 32 forks source link

Create separate github actions for various checks; get rid of monolithic tox.yml #123

Closed richm closed 1 year ago

richm commented 1 year ago

There are now separate github actions for the various tests, instead of all of them being done as part of the tox tests in tox.yml - ansible-lint, ansible-test, etc.

Use the officially supported github actions e.g. for ansible-lint, ansible-test, rather than using our own from tox-lsr and trying to keep up with the latest changes. Developers will still be able to use tox-lsr on their local development environments to run these tests in the same way that they are run in github actions, so that errors found when submitting PRs can be reproduced and corrected locally without too many github UI roundtrips.

Using separate github actions, and especially the official github actions which generally have support for in-line comments, should help greatly with readability and troubleshooting test results.

Python tests are removed from roles that do not use python.

Python tests are now done by python-unit-tests.yml which also does the black, flake8, and pylint tests.

Signed-off-by: Rich Megginson rmeggins@redhat.com

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4009421598

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 3970676095: 0.0%
Covered Lines: 425
Relevant Lines: 796

đź’› - Coveralls