Closed BrennanPaciorek closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.23
:tada:
Comparison is base (
f458cb4
) 53.39% compared to head (11bc6ba
) 53.62%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
ansible-lint: add var-naming[no-role-prefix]
to skip_list
in .ansible-lint
[citest]
You might find this useful - https://linux-system-roles.github.io/documentation/howto/working-with-ansible-jinja-code-and-filters.html - "How to solve some common ansible-lint issues"
[citest]
ansible-lint: add
var-naming[no-role-prefix]
toskip_list
in.ansible-lint
Should we add this in .github for all roles or am I missing something?
ansible-lint: add
var-naming[no-role-prefix]
toskip_list
in.ansible-lint
Should we add this in .github for all roles or am I missing something?
yes, we should - I don't see any other way around this, unfortunately
Great work, thank you so much!
Enhancement:
Reason: Better compliance with Ansible best practices for check mode (not failing in check mode, especially where they would not fail in diff mode) Reason for this particular solution - We cannot track changes from previous check modes without overhauling how check mode is handled throughout the entire system role.
Result: Undefined services being enabled or disabled will not result in failure while in check mode, but a warning will be displayed intended to prompt the user to confirm that the service is defined in a previous play, since the same action could result in failure when run in diff mode.
Issue Tracker Tickets (Jira or BZ if any):