Closed BrennanPaciorek closed 1 year ago
Patch and project coverage have no change.
Comparison is base (
156614e
) 53.62% compared to head (a586d09
) 53.62%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This may have become too complex to be just a bug fix, but if we are disabling nftables, I figured it would make sense to disable all known conflicting services and make it an argument for the role to reduce overhead in the cases where doing so is not necessary.
I can additionally separate the two fixes into separate PRs if necessary.
This may have become too complex to be just a bug fix, but if we are disabling nftables, I figured it would make sense to disable all known conflicting services and make it an argument for the role to reduce overhead in the cases where doing so is not necessary.
I can additionally separate the two fixes into separate PRs if necessary.
I think it's fine to have a single pr
[citest]
[citest]
We need to move the test from tests_default.yml - that test is only intended to run the role with no parameters. If you can alter another test, please do, otherwise, we will require a new test file.
We need to move the test from tests_default.yml - that test is only intended to run the role with no parameters. If you can alter another test, please do, otherwise, we will require a new test file.
Done. (new test file created, tests_default.yml reverted)
[citest]
Enhancement: Role will now always attempt to unmask on role execution
add variable 'firewall_disable_conflicting_services' to give the option of disabling of known conflicting services
Update README to document the following behavior of the system role:
linux-system-roles.firewall can attempt to disable directly conflicting services to firewalld
test cases for these changes in tests/tests_default.yml
Reason: role currently fails if firewalld was masked on run conflicting services have the potential to cause errors on role run
Result:
Issue Tracker Tickets (Jira or BZ if any):