search

linux-system-roles / firewall

Configure firewalld and system-config-firewall
https://linux-system-roles.github.io/firewall/
GNU General Public License v2.0
57 stars 32 forks source link

fix: facts being gathered unnecessarily #157

Closed richm closed 1 year ago

richm commented 1 year ago

Cause: The comparison of the present facts with the required facts is being done on unsorted lists.

Consequence: The comparison may fail if the only difference is the order. Facts are gathered unnecessarily.

Fix: Use difference which works no matter what the order is. Ensure that the fact gathering subsets used are the absolute minimum required.

Result: The role gathers only the facts it requires, and does not unnecessarily gather facts.

Signed-off-by: Rich Megginson rmeggins@redhat.com

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (c969ff4) 53.62% compared to head (6e4a2df) 53.62%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #157 +/- ## ======================================= Coverage 53.62% 53.62% ======================================= Files 2 2 Lines 800 800 ======================================= Hits 429 429 Misses 371 371 ``` | Flag | Coverage Δ | | |---|---|---| | sanity | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

richm commented 1 year ago

[citest]