codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 100.00% and project coverage change: +1.29% :tada:
Comparison is base (
9c6ad37) 53.62% compared to head (83e3f87) 54.92%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #162 +/- ## ========================================== + Coverage 53.62% 54.92% +1.29% ========================================== Files 2 2 Lines 800 823 +23 ========================================== + Hits 429 452 +23 Misses 371 371 ``` | Flag | Coverage Δ | | |---|---|---| | sanity | `∅ <ø> (∅)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/linux-system-roles/firewall/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [library/firewall\_lib.py](https://app.codecov.io/gh/linux-system-roles/firewall/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#diff-bGlicmFyeS9maXJld2FsbF9saWIucHk=) | `64.29% <100.00%> (+1.20%)` | :arrow_up: |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
richm
Enhancement: firewall varable option firewalld_conf added to support modifying supported firewalld_conf arguments
Reason: Many EL releases for firewalld set
AllowZoneDrifting=yesas the default. This feature allows those who do not want this insecure feature set to disable the feature using the role.Result: AllowZoneDrifting can be changed to whatever the role user wants to change it to, provided it is not deprecated.
Will fail if the system is using a version of firewalld where
AllowZoneDriftinghas not been implemented. This should not be an issue on EL7 since the feature seems to have been backported to those systems, and should not be an issue on systems where the feature is removed because the dbus method for modifying the directive is still present (although it does not do anything).Issue Tracker Tickets (Jira or BZ if any):