Closed BrennanPaciorek closed 1 year ago
Patch coverage: 90.90%
and project coverage change: +2.10%
:tada:
Comparison is base (
25dd295
) 54.92% compared to head (086e048
) 57.02%.:exclamation: Current head 086e048 differs from pull request most recent head f8675a1. Consider uploading reports for the commit f8675a1 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
can you add a unit test for this?
can you add a unit test for this?
Yes, working on this now.
PR was not updating with new commits, so I closed then reopened PR
[citest]
Enhancement: Make try_set_zone_of_interface in library/firewall_lib.py return a second value, which denotes whether the interface's zone was changed.
Reason: Network Manager interface assignment reported changed when no changes were present
Result: The module now properly reports changes when assigning zones to interfaces handled by Network Manager.
Issue Tracker Tickets (Jira or BZ if any):