linux-system-roles / firewall

Configure firewalld and system-config-firewall
https://linux-system-roles.github.io/firewall/
GNU General Public License v2.0
57 stars 32 forks source link

tests: test_ping: fix compatability issues #171

Closed BrennanPaciorek closed 1 year ago

BrennanPaciorek commented 1 year ago

Test script no longer fails if managed node does not support podman network create --interface name

Enhancement:

Reason: test fails on some platforms (RHEL 8.8, 9.2) due to podman not supporting podman network create --interface-name option

Result: Tests pass on managed nodes with podman versions < v4.4

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (d9be203) 61.05% compared to head (180b71e) 61.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #171 +/- ## ======================================= Coverage 61.05% 61.05% ======================================= Files 2 2 Lines 909 909 ======================================= Hits 555 555 Misses 354 354 ``` | Flag | Coverage Δ | | |---|---|---| | sanity | `∅ <ø> (∅)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

BrennanPaciorek commented 1 year ago

@richm These changes seem to fix the issue on the affected versions when tested on my machine, can you test out the PR as well?

richm commented 1 year ago

@richm These changes seem to fix the issue on the affected versions when tested on my machine, can you test out the PR as well?

lgtm - I added some debugging to make it easier to diagnose issues with this script in the future - https://github.com/BrennanPaciorek/firewall/pull/1

richm commented 1 year ago

[citest]