linux-system-roles / firewall

Configure firewalld and system-config-firewall
https://linux-system-roles.github.io/firewall/
GNU General Public License v2.0
57 stars 32 forks source link

fix: files: overwrite firewalld.conf on previous replaced #176

Closed BrennanPaciorek closed 1 year ago

BrennanPaciorek commented 1 year ago

on previous replaced, revert firewalld.conf to fallback configuration instead of deletion

Enhancement: Replaces firewalld.conf on previous replaced instead of deleting when changed

Reason: EL7+ firewalld releases appeared to support a fallback configuration in firewalld, which could be effectively used to override the previous configuration.

Result: On reset, firewalld.conf is not deleted, and comments in the file are retained.

Addresses GitHub issue #164

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (e4042f1) 61.05% compared to head (130d6d4) 61.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #176 +/- ## ======================================= Coverage 61.05% 61.05% ======================================= Files 2 2 Lines 909 909 ======================================= Hits 555 555 Misses 354 354 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/firewall/pull/176/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/firewall/pull/176/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `∅ <ø> (∅)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

BrennanPaciorek commented 1 year ago

Added some extra tests to verify that firewalld.conf won't change after running previous: replaced with no changes.

richm commented 1 year ago

[citest]

BrennanPaciorek commented 1 year ago

No additional changes planned. This is good to merge.