linux-system-roles / firewall

Configure firewalld and system-config-firewall
https://linux-system-roles.github.io/firewall/
GNU General Public License v2.0
58 stars 31 forks source link

ci: Use supported ansible-lint action; run ansible-lint against the collection #200

Closed richm closed 9 months ago

richm commented 9 months ago

The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The new ansible-lint has several checks related to ansible-test and the ignore files. Many of our ignore settings are not allowed any more and are required to be fixed or addressed in the Ansible preferred way.

The module documentation must comply with the Ansible standards.

The result of this is that the .sanity files can be reduced to the bare minimum which will greatly reduce the maintenance burden of those files, make it easier to support newer versions of Ansible, and make it easier to import the system roles collection into Galaxy and Automation Hub.

The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test.

Role developers can run this locally using tox -e collection,ansible-lint-collection See https://github.com/linux-system-roles/tox-lsr/pull/125

Add --- doc start to .markdownlint.yaml

Signed-off-by: Rich Megginson rmeggins@redhat.com

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (db3bb15) 61.05% compared to head (1e4eb7f) 61.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #200 +/- ## ========================================== + Coverage 61.05% 61.09% +0.04% ========================================== Files 2 2 Lines 909 910 +1 ========================================== + Hits 555 556 +1 Misses 354 354 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/firewall/pull/200/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/firewall/pull/200/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `∅ <ø> (∅)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.