linux-system-roles / firewall

Configure firewalld and system-config-firewall
https://linux-system-roles.github.io/firewall/
GNU General Public License v2.0
58 stars 31 forks source link

ci: Add conditional reboot for transactional update support #204

Closed HVSharma12 closed 8 months ago

HVSharma12 commented 8 months ago

Enhancement: Add Conditional Reboot and README.md Syntax Fix

Reason: To support transactional update systems that require a reboot for changes to take effect and to correct a syntax error in the firewall configuration example in the readme.md.

Result: Ensures that changes on transactional systems are applied correctly if a new package is installed.

Issue Tracker Tickets (Jira or BZ if any):na

richm commented 8 months ago

one minor nit, otherwise, lgtm

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f970b15) 61.09% compared to head (11af64e) 61.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #204 +/- ## ======================================= Coverage 61.09% 61.09% ======================================= Files 2 2 Lines 910 910 ======================================= Hits 556 556 Misses 354 354 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/firewall/pull/204/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/firewall/pull/204/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `∅ <ø> (∅)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.