[Draft] added changes so present and absent can be added to zones.

linux-system-roles / firewall

Configure firewalld and system-config-firewall

https://linux-system-roles.github.io/firewall/

GNU General Public License v2.0

58 stars 32 forks source link

[Draft] added changes so present and absent can be added to zones. #40

Closed vrindle closed 3 years ago

richm commented 3 years ago

@t-woerner this is for feature parity with ansible.posix.firewalld - https://docs.ansible.com/ansible/latest/collections/ansible/posix/firewalld_module.html#parameter-state "The states present and absent can only be used in zone level operations (i.e. when no other parameters but zone and state are set)."

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging 967b1c8311801dd280d3451d8b554ed165a263a1 into 8866b9ec92a9e1bb865d7617f6db2cf72156fb35 - view on LGTM.com

new alerts:

1 for Unnecessary pass
1 for Except block handles 'BaseException'

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging b59372fefc28fd221dd17d59f22cfbd6457a8bf8 into 8866b9ec92a9e1bb865d7617f6db2cf72156fb35 - view on LGTM.com

new alerts:

1 for Unnecessary pass
1 for Except block handles 'BaseException'

richm commented 3 years ago

I think this PR can be closed

richm commented 3 years ago

closing this PR as it has been addressed elsewhere - please reopen if this is in error