linux-system-roles / firewall

Configure firewalld and system-config-firewall
https://linux-system-roles.github.io/firewall/
GNU General Public License v2.0
58 stars 32 forks source link

Update interface so that interface can only be applied to one zone. #48

Closed vrindle closed 3 years ago

richm commented 3 years ago

I think you should make the interface/zone handling here a separate function, and then write some unit tests for that function.

richm commented 3 years ago

[citest pending]

richm commented 3 years ago

[citest pending]

richm commented 3 years ago

I'm assuming this code copied from a.p.firewalld is correct, but would appreciate if @t-woerner or @erig0 could take a quick look

richm commented 3 years ago

[citest]

richm commented 3 years ago

[citest]

richm commented 3 years ago

[citest bad]

richm commented 3 years ago

[citest]