search

linux-system-roles / kdump

An ansible role which configures kdump
https://linux-system-roles.github.io/kdump/
MIT License
19 stars 21 forks source link

check mode in ssh target support: "Cat file to register" will fail #25

Closed pcahyna closed 3 months ago

pcahyna commented 5 years ago

"Create key" should IMO not have check_mode: False, because it changes the managed host, and one should not do that in check mode. The problem then is that "Cat file to register" will fail, so this is not that easy to fix.

_Originally posted by @pcahyna in https://github.com/linux-system-roles/kdump/pull/23/review_comment/create_

pcahyna commented 5 years ago

Note that for proper ssh target support one needs #22

pcahyna commented 5 years ago

On a second thought, should we actually aim to fix such problems? See https://github.com/ansible/molecule/issues/128#issuecomment-245009843 I mean, failures in check mode when the role has not been executed yet without check mode. (If so, we should change the sequence in molecule testing to run "check" before "converge".)