search

linux-system-roles / mssql

Ansible role for managing MS SQL
https://linux-system-roles.github.io/mssql/
MIT License
27 stars 23 forks source link

odbc_driver_18 #302

Open devisbal opened 1 month ago

devisbal commented 1 month ago

Will it be possible to add the odbc_driver_18 Actually this is the only one available: accept_microsoft_odbc_driver_17_for_sql_server_eula

spetrosi commented 1 month ago

Hello @devisbal, this variable serves as a confirmation that user accepts EULA, same as other mssql_accept_* variables. This confirmation is required when you install mssql-server package. If these variables are not set to true, role fail, otherwise it proceeds and installs mssql-server package.

Are you saying that now mssql-server package requires odbc_driver version 18? If yes, this is not an issue because the role installs the driver version that is required by the mssql-server package.

The issue in naming, though, exists. I guess the best is to rename accept_microsoft_odbc_driver_17_for_sql_server_eula to remove version number, like accept_microsoft_odbc_driver_for_sql_server_eula to remove maintenance burden. With a note that accept_microsoft_odbc_driver_17_for_sql_server_eula will still be supported as deprecated for some time.

spetrosi commented 1 month ago

I confirm that there is a bug in the role, on RHEL 9 it installs mssql-tools-17 instead of mssql-tools18-18. I'll work with Microsoft to fix this. I don't think RHEL 9 requires mssql-tools-17 at all if version 18 is available.

spetrosi commented 1 month ago

Some updates on this, the role works fine with mssql-tools-17 that it installs. mssql-tools-18 has some additional functionality for editing databases, and because some of the new functionality is not backward-compatible, Microsoft added it in a separate package. Right now the role works fine. I will add a variable to install a newer mssql-tools-18 for those users who need it.