search

linux-system-roles / nbde_client

Ansible role for configuring Network Bound Disk Encryption clients (e.g. clevis)
https://linux-system-roles.github.io/nbde_client/
MIT License
14 stars 24 forks source link

ci: Use supported ansible-lint action; run ansible-lint against the collection #146

Closed richm closed 8 months ago

richm commented 8 months ago

The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The new ansible-lint has several checks related to ansible-test and the ignore files. Many of our ignore settings are not allowed any more and are required to be fixed or addressed in the Ansible preferred way.

The module documentation must comply with the Ansible standards. One aspect of this is the version_added must be a valid ansible-core version in X.Y.Z format. Note that this version isn't really used anywhere, so it doesn't matter for users of the role, it is purely an ansible-test and import gating issue. So removing it.

The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test.

Role developers can run this locally using tox -e collection,ansible-lint-collection See https://github.com/linux-system-roles/tox-lsr/pull/125

Add --- doc start to .markdownlint.yaml

Add cleanup to tests_include_vars_from_parent.yml

Signed-off-by: Rich Megginson rmeggins@redhat.com

richm commented 8 months ago

[citest]