search

linux-system-roles / nbde_client

Ansible role for configuring Network Bound Disk Encryption clients (e.g. clevis)
https://linux-system-roles.github.io/nbde_client/
MIT License
14 stars 24 forks source link

chore: add Rocky Linux vars files #175

Closed xeluior closed 1 week ago

xeluior commented 2 months ago

Enhancement: Adds support for Rocky Linux 8/9

Reason: I use Rocky Linux in my environment

Result: Vars files added for Rocky Linux 8/9

Issue Tracker Tickets (Jira or BZ if any): N/A

richm commented 3 weeks ago

@xeluior I think symlinks would be best - that is - the Rocky_N.yml files should just be symlinks to the corresponding RedHat_N.yml file. We have other roles using symlinks like this - https://github.com/linux-system-roles/ssh/tree/main/vars - which uses CentOS_N.yml as a symlink to the corresponding RedHat_N.yml - wdyt?

richm commented 3 weeks ago

@xeluior I have what I think is a more elegant solution, for all system roles - https://github.com/linux-system-roles/.github/pull/74

richm commented 3 weeks ago

@xeluior I have what I think is a more elegant solution, for all system roles - linux-system-roles/.github#74

and it looks like nbde_client is one of the "lucky" roles, that does not have tasks or vars based on conditionals such as ansible_distribution in ['CentOS', 'RedHat'] - this is a problem with Rocky/Alma support in several roles.

xeluior commented 1 week ago

@xeluior I have what I think is a more elegant solution, for all system roles - linux-system-roles/.github#74

Not sure I fully understand the linked PR, but if it adds Rocky support without needing these vars files we can probably close this PR.

richm commented 1 week ago

@xeluior I have what I think is a more elegant solution, for all system roles - linux-system-roles/.github#74

Not sure I fully understand the linked PR, but if it adds Rocky support without needing these vars files we can probably close this PR.

ok - the role now has support for Rocky due to https://github.com/linux-system-roles/nbde_client/pull/181 - please try this.