linux-system-roles / nbde_client

Ansible role for configuring Network Bound Disk Encryption clients (e.g. clevis)
https://linux-system-roles.github.io/nbde_client/
MIT License
14 stars 24 forks source link

Sets needed spacing for appended rd.neednet parameter #68

Closed whitehat237 closed 2 years ago

whitehat237 commented 2 years ago

In our limited testing, we've found that the appended rd.neednet parameter needs to have proper spacing between the quotes. I.E. kernel_cmdline+= " rd.neednet=1 " so that it's properly appended to the kernel command line.

When using a static IP, if the rd.neednet parameter does not have proper spacing, adapter link does not appear to be brought up. These commits modify the vars yaml file for each distro to use the spaced out parameter. Also changes = to += for the append operation.

richm commented 2 years ago

[citest commit:a6883c93d0c5d8cac24d13931d2dc1806f8849f8]

richm commented 2 years ago

[citest]

richm commented 2 years ago

lgtm - @sergio-correia ?

sergio-correia commented 2 years ago

LGTM as well, thanks.