linux-system-roles / network

An ansible role to configure networking
https://linux-system-roles.github.io/network/
BSD 3-Clause "New" or "Revised" License
238 stars 106 forks source link

feat: support for ostree systems #650

Closed richm closed 1 year ago

richm commented 1 year ago

Feature: Allow running and testing the role with ostree managed nodes.

Reason: We have users who want to use the role to manage ostree systems.

Result: Users can use the role to manage ostree managed nodes.

NOTE: The .ostree/packages-*.txt are generated by running the script https://github.com/linux-system-roles/auto-maintenance/blob/main/check-logs-for-packages.sh which is used with an integration test CI run with the https://github.com/linux-system-roles/auto-maintenance/blob/main/callback_plugins/dump_packages.py plugin. An example of such a CI run is https://github.com/linux-system-roles/network/pull/647

Signed-off-by: Rich Megginson rmeggins@redhat.com

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (712f1df) 43.28% compared to head (5b855b2) 43.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #650 +/- ## ======================================= Coverage 43.28% 43.28% ======================================= Files 13 13 Lines 3068 3068 Branches 394 394 ======================================= Hits 1328 1328 Misses 1740 1740 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/network/pull/650/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/network/pull/650/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `19.82% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

richm commented 1 year ago

[citest]

liangwen12year commented 1 year ago

[citest]

liangwen12year commented 1 year ago

All the github action container tests failed in

TASK [Include the task 'el_repo_setup.yml'] ************************************
fatal: [localhost]: FAILED! => {"reason": "couldn't resolve module/action 'ansible.utils.update_fact'. This often indicates a misspelling, missing collection, or incorrect module path.\n\nThe error appears to be in '/network-role/tests/tasks/el_repo_setup.yml': line 27, column 7, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n    - name: Set package manager to use for ostree\n      ^ here\n"}
liangwen12year commented 1 year ago

[citest]