linux-system-roles / network

An ansible role to configure networking
https://linux-system-roles.github.io/network/
BSD 3-Clause "New" or "Revised" License
238 stars 106 forks source link

refactor: Use meaningful variable #654

Closed liangwen12year closed 1 year ago

liangwen12year commented 1 year ago

Enhancement: refractor: Use meaningful variable

Reason: Some variables used in the module code are not meaningful at all, which mgiht be hard to read and understand. Therefore, replace them with meaningful variables.

Result:

Issue Tracker Tickets (Jira or BZ if any):

codecov[bot] commented 1 year ago

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (11fa80a) 43.31% compared to head (7e7dacf) 43.31%.

Files Patch % Lines
library/network_connections.py 23.52% 13 Missing :warning:
module_utils/network_lsr/argument_validator.py 71.42% 4 Missing :warning:
module_utils/network_lsr/utils.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #654 +/- ## ======================================= Coverage 43.31% 43.31% ======================================= Files 13 13 Lines 3068 3068 Branches 394 394 ======================================= Hits 1329 1329 Misses 1739 1739 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/network/pull/654/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/network/pull/654/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `19.82% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

liangwen12year commented 1 year ago

[citest]

liangwen12year commented 1 year ago

[citest]

liangwen12year commented 1 year ago

[citest]

liangwen12year commented 1 year ago

[citest]