Closed liangwen12year closed 10 months ago
Attention: 12 lines
in your changes are missing coverage. Please review.
Comparison is base (
735d4be
) 45.03% compared to head (cc592c2
) 45.00%.
Files | Patch % | Lines |
---|---|---|
library/network_connections.py | 8.33% | 11 Missing :warning: |
module_utils/network_lsr/argument_validator.py | 87.50% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[citest]
[citest]
[citest]
[citest]
[citest]
[citest bad]
[citest]
[citest]
[citest]
[citest]
[citest]
[citest]
@tyll , Thanks for the comments, I think that I addressed them all.
[citest]
[citest]
[citest]
Only minor remarks from me, I don't need to re-review this. I am fine with someone else approving this after the changes.
[citest]
[citest]
When users have BGP routing setups, it is common practice to blackhole some less-specific routes in order to avoid routing loops, and the BGP router might insert a more specific route dynamically afterwards.
Enhancement:
Reason:
Result:
Issue Tracker Tickets (Jira or BZ if any):