linux-system-roles / network

An ansible role to configure networking
https://linux-system-roles.github.io/network/
BSD 3-Clause "New" or "Revised" License
238 stars 106 forks source link

feat: Support blackhole, prohibit and unreachable route types #662

Closed liangwen12year closed 10 months ago

liangwen12year commented 11 months ago

When users have BGP routing setups, it is common practice to blackhole some less-specific routes in order to avoid routing loops, and the BGP router might insert a more specific route dynamically afterwards.

Enhancement:

Reason:

Result:

Issue Tracker Tickets (Jira or BZ if any):

codecov[bot] commented 11 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (735d4be) 45.03% compared to head (cc592c2) 45.00%.

Files Patch % Lines
library/network_connections.py 8.33% 11 Missing :warning:
module_utils/network_lsr/argument_validator.py 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #662 +/- ## ========================================== - Coverage 45.03% 45.00% -0.04% ========================================== Files 12 12 Lines 3080 3100 +20 Branches 428 433 +5 ========================================== + Hits 1387 1395 +8 - Misses 1692 1704 +12 Partials 1 1 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/network/pull/662/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/network/pull/662/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `20.50% <0.00%> (-0.12%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

liangwen12year commented 11 months ago

[citest]

liangwen12year commented 11 months ago

[citest]

liangwen12year commented 11 months ago

[citest]

liangwen12year commented 11 months ago

[citest]

liangwen12year commented 11 months ago

[citest]

liangwen12year commented 11 months ago

[citest bad]

liangwen12year commented 10 months ago

[citest]

liangwen12year commented 10 months ago

[citest]

liangwen12year commented 10 months ago

[citest]

liangwen12year commented 10 months ago

[citest]

liangwen12year commented 10 months ago

[citest]

liangwen12year commented 10 months ago

[citest]

liangwen12year commented 10 months ago

@tyll , Thanks for the comments, I think that I addressed them all.

liangwen12year commented 10 months ago

[citest]

liangwen12year commented 10 months ago

[citest]

liangwen12year commented 10 months ago

[citest]

tyll commented 10 months ago

Only minor remarks from me, I don't need to re-review this. I am fine with someone else approving this after the changes.

liangwen12year commented 10 months ago

[citest]

liangwen12year commented 10 months ago

[citest]