search

linux-system-roles / network

An ansible role to configure networking
https://linux-system-roles.github.io/network/
BSD 3-Clause "New" or "Revised" License
233 stars 106 forks source link

fix: add support for EL10 #700

Closed richm closed 2 months ago

richm commented 3 months ago

According to the Ansible team, support for listing platforms in role meta/main.yml files is being removed. Instead, they recommend using galaxy_tags

https://github.com/ansible/ansible/blob/stable-2.17/changelogs/CHANGELOG-v2.17.rst "Remove the galaxy_info field platforms from the role templates" https://github.com/ansible/ansible/issues/82453

Many roles already have tags such as "rhel", "redhat", "centos", and "fedora". I propose that we ensure all of the system roles have these tags. Some of our roles support Suse, Debian, Ubuntu, and others. We should add tags for those e.g. the ssh role already has tags for "debian" and "ubuntu".

In addition - for each version listed under platforms.EL - add a tag like elN.

Q: Why not use a delimiter between the platform and the version e.g. el-10?

This is not allowed by ansible-lint:

meta-no-tags: Tags must contain lowercase letters and digits only., invalid: 'el-10'
meta/main.yml:1

So we cannot use uppercase letters either.

Q: Why not use our own meta/main.yml field?

No other fields are allowed by ansible-lint:

syntax-check[specific]: 'myfield' is not a valid attribute for a RoleMetadata

Q: Why not use some other field?

There are no other applicable or suitable fields.

Q: What happens when we want to support versions like N.M?

Use the word "dot" instead of "." e.g. el10dot3. Similarly - use "dash" instead of "-".

We do not need tags such as fedoraall. The fedora tag implies that the role works on all supported versions of fedora. Otherwise, use tags such as fedora40 if the role only supports specific versions.

Teaming support is dropped in EL10. Provide an error to users who attempt to use teaming and suggest that they use bonding instead. Skip teaming tests on EL10.

Signed-off-by: Rich Megginson rmeggins@redhat.com

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.22%. Comparing base (34d1f2d) to head (a7d8d6f). Report is 11 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #700 +/- ## =========================================== + Coverage 20.50% 43.22% +22.72% =========================================== Files 10 12 +2 Lines 1478 3100 +1622 Branches 433 0 -433 =========================================== + Hits 303 1340 +1037 - Misses 1174 1760 +586 + Partials 1 0 -1 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/network/pull/700/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/network/pull/700/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

spetrosi commented 3 months ago

LGTM! It's weird that dashes are not allowed... You suggest a good workaround for this.