search

linux-system-roles / network

An ansible role to configure networking
https://linux-system-roles.github.io/network/
BSD 3-Clause "New" or "Revised" License
237 stars 106 forks source link

tests: Use EPEL-7 from archive #719

Closed jharuda closed 3 months ago

jharuda commented 3 months ago

Enhancement: Fix tests on EL-7

Reason: EL-7 test were failing due to missing EPEL-7 packages/repository

Result: EL-7 test should pass

Issue Tracker Tickets (Jira or BZ if any):

718

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.29%. Comparing base (89d7148) to head (8c22594). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #719 +/- ## =========================================== + Coverage 20.40% 43.29% +22.88% =========================================== Files 10 12 +2 Lines 1485 3109 +1624 Branches 436 0 -436 =========================================== + Hits 303 1346 +1043 - Misses 1181 1763 +582 + Partials 1 0 -1 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/network/pull/719/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/network/pull/719/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

richm commented 3 months ago

[citest]

spetrosi commented 3 months ago

[citest]

richm commented 3 months ago

I merged the fix for the failing fedora-39 and fedora-40 tests. @jharuda please rebase to the latest main branch. Also, the network role requires PRs to be signed with git commit -s - once you do the rebase, do a git commit -s --amend to add the signature, then git push -f ... your commit.

richm commented 3 months ago

I also merged the fix for the integration / integration tests