search

linux-system-roles / postfix

An ansible role which configures postfix
https://linux-system-roles.github.io/postfix/
GNU General Public License v3.0
14 stars 20 forks source link

ansible-lint reports errors #9

Closed vcrhonek closed 2 years ago

vcrhonek commented 5 years ago

--> Executing Ansible Lint on postfix/tests/tests_default.yml... [ANSIBLE0010] Package installs should not use latest postfix/tests/roles/linux-system-roles.postfix/tasks/main.yml:2 Task/Handler: Install Postfix

[ANSIBLE0013] Use shell only when shell functionality is required
postfix/tests/roles/linux-system-roles.postfix/tasks/main.yml:8
Task/Handler: Backup configuration

[ANSIBLE0012] Commands should not change things if nothing needs doing
postfix/tests/roles/linux-system-roles.postfix/tasks/main.yml:28
Task/Handler: Configure Postfix
richm commented 3 years ago

@nhosoi I never could get tox working for this role - so we may have to fix ansible-lint/ansible-test issues in this role by running ansible-lint and ansible-test sanity manually

spetrosi commented 2 years ago

Tox tests are running on the role properly now