search

linux-system-roles / rhc

Role to manage RH subscription management and Insights
https://linux-system-roles.github.io/rhc/
MIT License
9 stars 15 forks source link

fix: drop usage of "auto_attach" of the "redhat_subscription" module #189

Closed ptoscano closed 1 month ago

ptoscano commented 1 month ago

auto_attach is supposed to automatically attach subscriptions for accounts in entitlement mode. in Simple Content Access mode, this option becomes a no-op in subscription-manager.

The usage of this option was originally added to help testing regardless of the content access mode, even if the role supports only SCA. Since the entitlement mode has been officially deprecated for a couple of years already, and it is going away soon, then stop using the auto_attach option of the redhat_subscription module.

There is no behaviour change.

ptoscano commented 1 month ago

[citest]

ptoscano commented 1 month ago

[citest bad]

spetrosi commented 1 month ago

Won't this break EL 7, 8, 9?

spetrosi commented 1 month ago

Please rebase

ptoscano commented 1 month ago

Won't this break EL 7, 8, 9?

Nope; SCA works fine in those versions.

ptoscano commented 1 month ago

[citest]

ptoscano commented 1 month ago

hmmm tests_repositories fails now:

This system has no repositories available through subscriptions

I guess I need to tweak the test data - will need to tweak the test setup a bit.

richm commented 1 month ago

hmmm tests_repositories fails now:

This system has no repositories available through subscriptions

I guess I need to tweak the test data - will need to tweak the test setup a bit.

ok - but it is not related to this PR

ptoscano commented 1 month ago

hmmm tests_repositories fails now:

This system has no repositories available through subscriptions

I guess I need to tweak the test data - will need to tweak the test setup a bit.

ok - but it is not related to this PR

True, however the result is that the tests are broken :/

I should have hopefully fixed my candlepin-unofficial container image, and local changes to switch the testing account seems to work fine.

I'll need #191 to fix one issue in the test setup, and then I can switch the account to a SCA one.

ptoscano commented 1 month ago

I'll need #191 to fix one issue in the test setup, and then I can switch the account to a SCA one.

... which is #195, hopefully.

ptoscano commented 1 month ago

[citest]

ptoscano commented 1 month ago

Now it should be fine :-)