linux-system-roles / ssh

Ansible role for configuring ssh clients
https://linux-system-roles.github.io/ssh/
GNU Lesser General Public License v3.0
19 stars 17 forks source link

ci: Run Fedora/CentOS CI in GH Actions + unbreak debian buster CI run #135

Closed Jakuje closed 10 months ago

Jakuje commented 10 months ago

Enhancement: Run tests on Fedora and CentOS

Reason: The downstream testing is down-sizing and moving upstream

Result: We are able to catch issues earlier in upstream.

Issue Tracker Tickets (Jira or BZ if any): -

Jakuje commented 10 months ago

Fixes for the debian buster live here: https://github.com/roles-ansible/check-ansible-debian-buster-action/pull/4

Note, that the buster is getting phased out by Ansible as I am getting the errors new ansible will not be supported on the native python 3.7.x:

[DEPRECATION WARNING]: Ansible will require Python 3.8 or newer on the controller starting with Ansible 2.12. Current
Jakuje commented 10 months ago

The debian action was fixed now. But Fedora for some reason does not work and I was not able to reproduce this in local container. Any hint why it should be failing would be welcomed.

richm commented 10 months ago

The debian action was fixed now. But Fedora for some reason does not work and I was not able to reproduce this in local container. Any hint why it should be failing would be welcomed.

Don't know - strange. Try adding the environment variable ANSIBLE_VERBOSITY: "2" to the fedora github action.

Jakuje commented 10 months ago

The debian action was fixed now. But Fedora for some reason does not work and I was not able to reproduce this in local container. Any hint why it should be failing would be welcomed.

Don't know - strange. Try adding the environment variable ANSIBLE_VERBOSITY: "2" to the fedora github action.

Good idea.

Looks like the getent_passwd is set in to the ansible_facts so should I access it from there as ansible_facts['getent_passwd'][username][4].

https://docs.ansible.com/ansible/latest/collections/ansible/builtin/getent_module.html

richm commented 10 months ago

minor linter issues, otherwise, lgtm

Jakuje commented 10 months ago

Thanks for the review! Squashed and cleaned up.

richm commented 10 months ago

@Jakuje looks like the same change for Fedora needs to be made to sshd - https://github.com/willshersystems/ansible-sshd/actions/runs/7451303938/job/20272119608?pr=272

Jakuje commented 10 months ago

@Jakuje looks like the same change for Fedora needs to be made to sshd - https://github.com/willshersystems/ansible-sshd/actions/runs/7451303938/job/20272119608?pr=272

yeah. Commented there we have it in the outstanding PR willshersystems/ansible-sshd#267. I can pull it into separate PR if needed.