search

linux-system-roles / ssh

Ansible role for configuring ssh clients
https://linux-system-roles.github.io/ssh/
GNU Lesser General Public License v3.0
19 stars 17 forks source link

Use custom shellcheck github action #75

Closed nhosoi closed 1 year ago

nhosoi commented 1 year ago

Use custom shellcheck github action

The upstream repo for the differential shellcheck action: https://github.com/redhat-plumbers-in-action/differential-shellcheck

Jakuje commented 1 year ago

We have shell script https://github.com/linux-system-roles/ssh/blob/main/.dev-tools/make_option_list even though it does not have the correct extension (not sure if the shellcheck was picking up on this path). If so, I would keep the action.

richm commented 1 year ago

We have shell script https://github.com/linux-system-roles/ssh/blob/main/.dev-tools/make_option_list even though it does not have the correct extension (not sure if the shellcheck was picking up on this path). If so, I would keep the action.

Ok. Noriko, please also add to https://github.com/linux-system-roles/.github/blob/main/inventory/inventory.yml#L137

nhosoi commented 1 year ago

Sorry, I should have remembered that... I've updated the pr. Thanks!