linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
101 stars 59 forks source link

Version 1.9.0 - CHANGELOG.md [citest skip] #285

Closed richm closed 2 years ago

richm commented 2 years ago

[1.9.0] - 2022-07-19

New Features

Fixes: #252

For LVM pools this adds support for adding and removing members (PVs) from the pool (VG).

Bug Fixes

If you use

  loop_control:
    loop_var: storage_test_pool

Then the variable storage_test_pool is scoped local to the task and is undefined after the task. In addition, referencing the variable after the loop causes this warning:

[WARNING]: The loop variable 'storage_test_pool' is already in use. You should
set the `loop_var` value in the `loop_control` option for the task to something
else to avoid variable collisions and unexpected behavior.

Looks like ansible-core-2.13 (or latest jinja3) does not support constructs like this:

var: "{{ [some list] }} + {{ [other list] }}"

instead, the entire thing has to be evaluated in the same jinja evaluation context:

var: "{{ [some list] + [other list] }}"

In addition - it is an Ansible antipattern to use

- set_fact:
    var: "{{ var + item }}"
    loop: "{{ some_list }}"

so that was rewritten to use filters instead

Other Changes

Ensure tests work when using ANSIBLE_GATHERING=explicit

The Ansible developers say that min_ansible_version in meta/main.yml must be a string value like "2.9", not a float value like 2.9.

Multiple bugs in blivet were fixed in order to make the feature work and without the correct version even the most basic test to remove a PV from a VG will fail so we should skip the entire test with old versions of blivet. Skip test on el7 if blivet version is too old Add support for is_rhel7 Refactor EL platform and version checking code Add a name for the end_play task

Signed-off-by: Rich Megginson rmeggins@redhat.com