search

linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
101 stars 59 forks source link

Master thin support size fix #299

Closed japokorn closed 2 years ago

richm commented 2 years ago

[citest]

richm commented 2 years ago

[citest]

richm commented 2 years ago

@japokorn please rebase on top of the latest master branch to pick up some of the test fixes

richm commented 2 years ago

Unfortunately we are having issues with CI testing for the storage role - it takes many hours to process - and unfortunately the only way to know if these changes you are making to the error messages affect any tests is to run all of them - you can certainly do that locally with tox and tox-lsr https://github.com/linux-system-roles/tox-lsr#qemu-testing

for testpb in tests/tests_*.yml; do
  tox -e qemu-ansible-core-2.13 -- --image-name centos-9 "$testpb" > "$testpb".log 2>&1
done

but that will also take a few hours In the meantime, if you have some code that you want to test, I might be able to hack something together.

japokorn commented 2 years ago

Rebased. Now running the tests locally.

japokorn commented 2 years ago

I have fixed tests_resize.yml checks so they match modified values. No other test was failing. (except tests_include_vars_from_parent.yml which is unrelated to the issue)

richm commented 2 years ago

[citest]