linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
102 stars 59 forks source link

Fix ansible-lint issues in tests #340

Closed richm closed 1 year ago

richm commented 1 year ago

All tasks must be named Task names must begin with uppercase letter Fix Jinja spacing issues Fix long lines with appropriate wrapping Do not use {{ .... }} in when and that conditionals Some tests were using safe_mode instead of storage_safe_mode LUKS tests were using regex_search incorrectly and always passing - use is search instead and fix pattern to parse luksdump output correctly. Refactor tests that check for the role to raise an error - add a new file verify-role-failed.yml which checks for ansible errors and blivet errors

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (9c616e6) 13.90% compared to head (9d475dd) 13.90%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #340 +/- ## ======================================= Coverage 13.90% 13.90% ======================================= Files 8 8 Lines 1705 1705 Branches 71 71 ======================================= Hits 237 237 Misses 1468 1468 ``` | Flag | Coverage Δ | | |---|---|---| | sanity | `16.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

richm commented 1 year ago

[citest]

richm commented 1 year ago

[citest]