search

linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
102 stars 59 forks source link

feat: User-specified mount point owner and permissions #352

Closed japokorn closed 1 year ago

japokorn commented 1 year ago

Added new volume options related to mount point directory: mount_user - directory owner (string) mount_group - directory group (string) mount_permissions - directory permissions (string; same format as chmod)

Resolves: rhbz#2181661

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -1.71 :warning:

Comparison is base (1b4b4c5) 13.90% compared to head (cfd7781) 12.19%.

:exclamation: Current head cfd7781 differs from pull request most recent head 14328ba. Consider uploading reports for the commit 14328ba to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #352 +/- ## ========================================== - Coverage 13.90% 12.19% -1.71% ========================================== Files 8 8 Lines 1705 1705 Branches 71 0 -71 ========================================== - Hits 237 208 -29 - Misses 1468 1497 +29 ``` | Flag | Coverage Δ | | |---|---|---| | sanity | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/linux-system-roles/storage/pull/352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [library/blivet.py](https://app.codecov.io/gh/linux-system-roles/storage/pull/352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#diff-bGlicmFyeS9ibGl2ZXQucHk=) | `0.00% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/linux-system-roles/storage/pull/352/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

richm commented 1 year ago

Also need an update to the README.md

richm commented 1 year ago

Did you push your new commit(s)?

japokorn commented 1 year ago

Did you push your new commit(s)?

My apologies, I am replying to comments that I have fixed locally, so I know I have handled them. Anyways I am mostly done.

richm commented 1 year ago

[citest]

richm commented 1 year ago

Did you push your new commit(s)?

My apologies, I am replying to comments that I have fixed locally, so I know I have handled them. Anyways I am mostly done.

Looks good now.