linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
101 stars 58 forks source link

feat: Add support for setting stripe size for LVM RAID #357

Closed vojtechtrefny closed 1 year ago

vojtechtrefny commented 1 year ago

Custom stripe size is required for SAP HANA setups.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.04 :warning:

Comparison is base (6388626) 13.90% compared to head (8adb941) 13.86%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #357 +/- ## ========================================== - Coverage 13.90% 13.86% -0.04% ========================================== Files 8 8 Lines 1705 1709 +4 Branches 71 71 ========================================== Hits 237 237 - Misses 1468 1472 +4 ``` | Flag | Coverage Δ | | |---|---|---| | sanity | `16.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/linux-system-roles/storage/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [library/blivet.py](https://app.codecov.io/gh/linux-system-roles/storage/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#diff-bGlicmFyeS9ibGl2ZXQucHk=) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

richm commented 1 year ago

[citest]

vojtechtrefny commented 1 year ago

The tests are now failing with

failed to set up volume 'lv1': __init__() got an unexpected keyword argument 'stripe_size'

because we don't have the latest version of blivet (which adds support for setting stripe_size for LVs), but the test should be skipped in this case. I am not sure why the version based skipping isn't working here correctly, I am looking into this.

vojtechtrefny commented 1 year ago

The tests are now failing with

failed to set up volume 'lv1': __init__() got an unexpected keyword argument 'stripe_size'

because we don't have the latest version of blivet (which adds support for setting stripe_size for LVs), but the test should be skipped in this case. I am not sure why the version based skipping isn't working here correctly, I am looking into this.

The skipping of the stripe size test case works correctly, this was actually a bug -- I was passing the stripe_size option even if stripe size wasn't specified so all the test cases were failing with old blivet. This should be fixed now.

vojtechtrefny commented 1 year ago

[citest]

richm commented 1 year ago

[citest]