linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
101 stars 58 forks source link

test: use storage_safe_mode_arg for verify-role-failed argument #368

Closed richm closed 1 year ago

richm commented 1 year ago

Some tests want to set storage_safe_mode globally for all use cases in the test. However, this doesn't work with verify-role-failed.yml because you can't do

include_tasks: verify-role-failed.yml
vars:
  storage_safe_mode: "{{ storage_safe_mode }}"

and also because verify-role-failed.yml requires an explicit storage_safe_mode argument.

So, use an intermediate variable storage_safe_mode_arg to hold the "global" setting of storage_safe_mode to pass to verify-role-failed.yml:

include_tasks: verify-role-failed.yml
vars:
  storage_safe_mode: "{{ storage_safe_mode_arg }}"

Signed-off-by: Rich Megginson rmeggins@redhat.com

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (d6b7a98) 13.70% compared to head (37fafeb) 13.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #368 +/- ## ======================================= Coverage 13.70% 13.70% ======================================= Files 8 8 Lines 1729 1729 Branches 71 71 ======================================= Hits 237 237 Misses 1492 1492 ``` | Flag | Coverage Δ | | |---|---|---| | sanity | `16.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.