linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
101 stars 58 forks source link

ci: ansible-lint - ignore var-naming[no-role-prefix] #371

Closed richm closed 1 year ago

richm commented 1 year ago

ansible-lint has recently added a check for this. It flags a lot of our test code, and some of our role code that uses nested roles. There is no easy way to disable it for these cases only. It would be a tremendous amount of work to add # noqa comments everywhere. The use of .ansible-lint-ignore would be a maintenance burden (cannot use tests/tests_*.yml or other similar wildcard to match all test files), would still issue a lot of warning messages, and would not solve all of the problems. The only way for now is to skip this rule.

Signed-off-by: Rich Megginson rmeggins@redhat.com

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (d95e590) 13.70% compared to head (76c950c) 13.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #371 +/- ## ======================================= Coverage 13.70% 13.70% ======================================= Files 8 8 Lines 1729 1729 Branches 71 71 ======================================= Hits 237 237 Misses 1492 1492 ``` | Flag | Coverage Δ | | |---|---|---| | sanity | `16.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.