search

linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
104 stars 59 forks source link

Update enable_coprs.yml #409

Closed real-joshua closed 11 months ago

real-joshua commented 11 months ago

Add missing "when" statement

Enhancement:

This adds a "when" statement that is missing.

Reason:

The 1st and 3rd task check whether the variable is defined, but the 2nd does not. Therefore if the variable is not defined this task file's execution will fail at the 2nd task and the check that is part of the 3rd task will never have any effect.

Result:

Execution will no longer fail at the 2nd task if the variable is not defined, instead it will continue to the third which then again checks whether the variable is defined.

Issue Tracker Tickets (Jira or BZ if any):

richm commented 11 months ago

@real-joshua thanks - how are you seeing this error? It looks like a real problem, but I cannot figure out how to reproduce it.

real-joshua commented 11 months ago

Never mind, now that I read it again this makes no sense. I misread _storage_copr_support_packages as _storage_copr_packages. :D

richm commented 11 months ago

Did you mean to close this PR? I often hit the Close button when I mean to add a Comment. If you didn't mean to close - my questions from https://github.com/linux-system-roles/storage/pull/409#issuecomment-1857119445 still apply

real-joshua commented 11 months ago

Did you mean to close this PR?

Yes, I noticed that my thought made no sense.