search

linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
99 stars 55 forks source link

feat: Enable GFS2 support in blivet #418

Closed vojtechtrefny closed 5 months ago

vojtechtrefny commented 5 months ago

GFS2 is supported by blivet, but the support is disabled by default so we need to enable it.

Fixes: #417

codecov[bot] commented 5 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (98cd81f) 13.30% compared to head (030258d) 13.29%.

Files Patch % Lines
library/blivet.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #418 +/- ## ========================================== - Coverage 13.30% 13.29% -0.01% ========================================== Files 8 8 Lines 1781 1782 +1 Branches 79 79 ========================================== Hits 237 237 - Misses 1544 1545 +1 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/storage/pull/418/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/storage/pull/418/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `16.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

richm commented 5 months ago

This breaks most of the tests. I've run tests on centos-9 and centos-8 and they fail with

TASK [linux-system-roles.storage : Manage the pools and volumes to match the specified state] ***
task path: /home/rmeggins/linux-system-roles/storage/tests/roles/linux-system-roles.storage/tasks/main-blivet.yml:84
...
MSG:

Failed to commit changes to disk: makes no sense to write a label when accepting default label
vojtechtrefny commented 5 months ago

This breaks most of the tests. I've run tests on centos-9 and centos-8 and they fail with

Sorry, should be fixed now.

richm commented 5 months ago

What is the relationship between fs_label and fs_type gfs2?

vojtechtrefny commented 5 months ago

What is the relationship between fs_label and fs_type gfs2?

I have added comment explaining this in test-verify-volume-fs.yml. The problem is that blivet doesn't support specifying label when creating GFS2 so it has to be specified with the -t option passed manually in fs_create_options which means the verification will always fail -- label is set (we get that information from lsblk), but we didn't specify label in fs_label.