linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
104 stars 59 forks source link

ci: fix python unit test - copy pytest config to tests/unit #423

Closed richm closed 9 months ago

richm commented 9 months ago

This is fixed by tox-lsr 3.2.2 - all actions that use tox-lsr are updated to 3.2.2, not just the python unit tests, even though the fix is only related to pytest. All roles are updated to use tox-lsr 3.2.2 for the sake of consistency even if not affected by the pytest issue.

Something changed recently in the way github actions provisions systems which means some of the directories are not readable by the python unit test actions. In addition, the python unit tests were causing a lot of unnecessary directory traversal doing collection/discovery of unit test files, because of using pytest -c /path/to/tox-lsr/pytest.ini Unfortunately, with pytest, the directory of the config file is the root directory for the tests and tests discovery, and there is no way around this.

Therefore, the only solution is to copy the tox-lsr pytest.ini to the tests/unit directory, which makes that the test root directory.

See also https://github.com/linux-system-roles/tox-lsr/pull/160

Signed-off-by: Rich Megginson rmeggins@redhat.com

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b7b87af) 16.54% compared to head (ef2eb7c) 16.54%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #423 +/- ## ======================================= Coverage 16.54% 16.54% ======================================= Files 2 2 Lines 284 284 Branches 79 79 ======================================= Hits 47 47 Misses 237 237 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/storage/pull/423/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/storage/pull/423/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `16.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.