linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
104 stars 59 forks source link

fix: Fix recreate check for formats without labelling support #435

Closed vojtechtrefny closed 7 months ago

vojtechtrefny commented 7 months ago

Formats like LUKS or LVMPV don't support labels so we need to skip the label check in BlivetVolume._reformat.

Resolves: RHEL-29874

(The second commit is just partially related to this, I found that issue when testing with LUKS which also doesn't have label support in blivet.)

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 11.65%. Comparing base (acd20be) to head (01e09cf).

Files Patch % Lines
library/blivet.py 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #435 +/- ## ========================================== - Coverage 16.54% 11.65% -4.90% ========================================== Files 2 8 +6 Lines 284 1784 +1500 Branches 79 0 -79 ========================================== + Hits 47 208 +161 - Misses 237 1576 +1339 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/storage/pull/435/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/storage/pull/435/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.