linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
104 stars 59 forks source link

fix: Fix 'possibly-used-before-assignment' pylint issues #440

Closed vojtechtrefny closed 5 months ago

vojtechtrefny commented 6 months ago

Latest pylint added a new check for values used before assignment. This fixes these issues found in the blivet module. Some of these are false positives, some real potential issues.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 11.65%. Comparing base (acd20be) to head (967748e). Report is 3 commits behind head on main.

Files Patch % Lines
library/blivet.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #440 +/- ## ========================================== - Coverage 16.54% 11.65% -4.90% ========================================== Files 2 8 +6 Lines 284 1785 +1501 Branches 79 0 -79 ========================================== + Hits 47 208 +161 - Misses 237 1577 +1340 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/storage/pull/440/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/storage/pull/440/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

richm commented 5 months ago

@vojtechtrefny lgtm - ready to merge?