search

linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
99 stars 55 forks source link

fix: Get same sector size disks for multi device LVM tests #441

Closed vojtechtrefny closed 1 month ago

vojtechtrefny commented 1 month ago

LVM doesn't allow creating VGs on top of disks with different sector sizes and when running our tests on machine with disks with both 512 and 4096 sectors LVM tests that use multiple disks can fail. This change adds a new option to the find_unused_disks module to request disks with the same sector sizes and uses this new option in the LVM tests that use multiple disks.

Issue Tracker Tickets (Jira or BZ if any): RHEL-25994

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.54%. Comparing base (acd20be) to head (bf4320b). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #441 +/- ## ======================================= Coverage 16.54% 16.54% ======================================= Files 2 2 Lines 284 284 Branches 79 79 ======================================= Hits 47 47 Misses 237 237 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/storage/pull/441/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/storage/pull/441/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `16.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vojtechtrefny commented 1 month ago

Does this require a description in README/

The find_unused_disks module is not public, we use it only in tests.