linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
104 stars 59 forks source link

fix: Fix expected error message in tests_misc.yml #446

Closed vojtechtrefny closed 5 months ago

vojtechtrefny commented 5 months ago

Different versions of blivet return a different error message when trying to create a filesystem with invalid parameters.

On Fedora 39 and older: "Failed to commit changes to disk: (FSError('format failed: 1'), '/dev/mapper/foo-test1')"

On Fedora 40 and newer: "Failed to commit changes to disk: Process reported exit code 1: mke2fs: invalid block size - 512\n"

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 11.64%. Comparing base (acd20be) to head (d6c8d95). Report is 11 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #446 +/- ## ========================================== - Coverage 16.54% 11.64% -4.91% ========================================== Files 2 8 +6 Lines 284 1795 +1511 Branches 79 0 -79 ========================================== + Hits 47 209 +162 - Misses 237 1586 +1349 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/storage/pull/446/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/storage/pull/446/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

richm commented 5 months ago

[citest]

richm commented 5 months ago

@vojtechtrefny please rebase on top of the latest main to fix the get_unused_disk issue

vojtechtrefny commented 5 months ago

[citest]