search

linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
104 stars 59 forks source link

test: lvm pool members test fix #449

Closed japokorn closed 5 months ago

japokorn commented 5 months ago

tests_lvm_pool_members started to fail. It tried to create a device with a requested size (20m) that was less than minimal allowed size (300m) for that type of volume. Role automatically resized the device to allowed size. That lead to discrepancy in actual and expected size values.

Increasing the requested device size to be same or larger than minimal fixes the issue.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 11.64%. Comparing base (acd20be) to head (64d6890). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #449 +/- ## ========================================== - Coverage 16.54% 11.64% -4.91% ========================================== Files 2 8 +6 Lines 284 1795 +1511 Branches 79 0 -79 ========================================== + Hits 47 209 +162 - Misses 237 1586 +1349 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/storage/pull/449/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/storage/pull/449/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

japokorn commented 5 months ago

[citest]

spetrosi commented 5 months ago

Sounds like it should be a tests: rather than fix: because it doesn't fix anything in the role. Please change the PR title.

japokorn commented 5 months ago

Changed PR name and commit message to start with test instead of fix