codecov[bot]
commented
5 months ago Codecov Report
Attention: Patch coverage is 9.52381% with 19 lines in your changes missing coverage. Please review.
Project coverage is 10.76%. Comparing base (
bb51979) to head (e091d3e).
| Files | Patch % | Lines |
|---|---|---|
| library/find_unused_disk.py | 9.52% | 19 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #452 +/- ## ========================================== - Coverage 16.54% 10.76% -5.79% ========================================== Files 2 8 +6 Lines 284 1942 +1658 Branches 79 0 -79 ========================================== + Hits 47 209 +162 - Misses 237 1733 +1496 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/storage/pull/452/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/storage/pull/452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
According to the Ansible team, support for listing platforms in role
meta/main.ymlfiles is being removed. Instead, they recommend usinggalaxy_tagshttps://github.com/ansible/ansible/blob/stable-2.17/changelogs/CHANGELOG-v2.17.rst "Remove the galaxy_info field platforms from the role templates" https://github.com/ansible/ansible/issues/82453
Many roles already have tags such as "rhel", "redhat", "centos", and "fedora". I propose that we ensure all of the system roles have these tags. Some of our roles support Suse, Debian, Ubuntu, and others. We should add tags for those e.g. the ssh role already has tags for "debian" and "ubuntu".
In addition - for each version listed under
platforms.EL- add a tag likeelN.Q: Why not use a delimiter between the platform and the version e.g.
el-10?This is not allowed by ansible-lint:
So we cannot use uppercase letters either.
Q: Why not use our own meta/main.yml field?
No other fields are allowed by ansible-lint:
Q: Why not use some other field?
There are no other applicable or suitable fields.
Q: What happens when we want to support versions like
N.M?Use the word "dot" instead of "." e.g.
el10dot3. Similarly - use "dash" instead of "-".We do not need tags such as
fedoraall. Thefedoratag implies that the role works on all supported versions of fedora. Otherwise, use tags such asfedora40if the role only supports specific versions.In addition - for roles that have different variable files for EL9, create the corresponding EL10 files.
Change find_unused_disk.py so that it will never return a nvme disk unless it is specifically asked for that type of disk. The issue was that every test was using an nvme disk.
Signed-off-by: Rich Megginson rmeggins@redhat.com