Closed vojtechtrefny closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 10.76%. Comparing base (
bb51979
) to head (5e93dab
). Report is 2 commits behind head on main.:exclamation: There is a different number of reports uploaded between BASE (bb51979) and HEAD (5e93dab). Click for more details.
HEAD has 1 upload less than BASE
| Flag | BASE (bb51979) | HEAD (5e93dab) | |------|------|------| |sanity|1|0|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
what about addressing concerns in https://github.com/linux-system-roles/storage/issues/437 and https://github.com/linux-system-roles/storage/issues/428 and https://github.com/linux-system-roles/storage/issues/385
what about addressing concerns in #437 and #428 and #385
Good point, I've updated the PR to cover these issues too.
Missing information about Stratis support, default value for
grow_to_fill
, notes about pool type-specific arguments etc.Resolves: https://github.com/linux-system-roles/storage/issues/455 Resolves: https://github.com/linux-system-roles/storage/issues/428 Resolves: https://github.com/linux-system-roles/storage/issues/385 Related: https://github.com/linux-system-roles/storage/issues/437