search

linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
102 stars 59 forks source link

fix: Remove partition table from disk removed from a VG #464

Closed vojtechtrefny closed 2 months ago

vojtechtrefny commented 3 months ago

When removing a PV from a VG we currently remove only the PV partition and not the partition table on the disk. This fixes this by removing the partition table too.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 10.73%. Comparing base (bb51979) to head (6f6f115). Report is 7 commits behind head on main.

Files Patch % Lines
library/blivet.py 0.00% 15 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (bb51979) and HEAD (6f6f115). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (bb51979) | HEAD (6f6f115) | |------|------|------| |sanity|1|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #464 +/- ## ========================================== - Coverage 16.54% 10.73% -5.81% ========================================== Files 2 8 +6 Lines 284 1946 +1662 Branches 79 0 -79 ========================================== + Hits 47 209 +162 - Misses 237 1737 +1500 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/storage/pull/464/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/storage/pull/464/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

richm commented 3 months ago

@vojtechtrefny looks good - did something change in el10? Because if I look at the output of wipefs -n at the end of tests_lvm_pool_members.yml with el9, the partition table is removed, even without this change

richm commented 3 months ago

@vojtechtrefny looks good - did something change in el10? Because if I look at the output of wipefs -n at the end of tests_lvm_pool_members.yml with el9, the partition table is removed, even without this change

Sorry, I'm wrong - on centos-9 there is a partition table, but it is different.

DEVICE OFFSET TYPE UUID LABEL
sda    0x1fe  dos
spetrosi commented 3 months ago

[citest]

richm commented 2 months ago

@spetrosi https://dl.fedoraproject.org/pub/alt/linuxsystemroles/logs/tf_storage-464_CentOS-Stream-10-2.17_20240801-082216/artifacts - I don't see any failures, but the github action result is failed?

richm commented 2 months ago

@spetrosi https://dl.fedoraproject.org/pub/alt/linuxsystemroles/logs/tf_storage-464_CentOS-Stream-10-2.17_20240801-082216/artifacts - I don't see any failures, but the github action result is failed?

not all of the tests ran - did the test run get killed by some sort of timeout? One problem with the storage tests is that they take hours to complete - may need to increase resources/timeout - maybe testing farm is killing the test because it takes too long.