search

linux-system-roles / storage

Ansible role for linux storage management
https://linux-system-roles.github.io/storage/
MIT License
104 stars 59 forks source link

test: use pvcreate with a timeout and verbose logging #476

Closed richm closed 3 months ago

richm commented 3 months ago

the pvcreate call gives us problems, and different problems on different platforms. Use timeout 30s to avoid hangs when it tries to read from stdin. Use verbose -vvv to figure out why it hangs/fails. Use -y to make it not ask questions and continue anyway.

Signed-off-by: Rich Megginson rmeggins@redhat.com

richm commented 3 months ago

[citest]

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 10.73%. Comparing base (e6cab70) to head (5e23056). Report is 2 commits behind head on main.

:exclamation: There is a different number of reports uploaded between BASE (e6cab70) and HEAD (5e23056). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (e6cab70) | HEAD (5e23056) | |------|------|------| |sanity|1|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #476 +/- ## ========================================== - Coverage 16.54% 10.73% -5.81% ========================================== Files 2 8 +6 Lines 284 1946 +1662 Branches 79 0 -79 ========================================== + Hits 47 209 +162 - Misses 237 1737 +1500 ``` | [Flag](https://app.codecov.io/gh/linux-system-roles/storage/pull/476/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/linux-system-roles/storage/pull/476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=linux-system-roles#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.