search

linux-system-roles / template

example template for creating new subsystem roles
https://linux-system-roles.github.io/template/
MIT License
13 stars 20 forks source link

fix: facts being gathered unnecessarily #111

Closed richm closed 1 year ago

richm commented 1 year ago

Cause: The comparison of the present facts with the required facts is being done on unsorted lists.

Consequence: The comparison may fail if the only difference is the order. Facts are gathered unnecessarily.

Fix: Use difference which works no matter what the order is. Ensure that the fact gathering subsets used are the absolute minimum required.

Result: The role gathers only the facts it requires, and does not unnecessarily gather facts.

Signed-off-by: Rich Megginson rmeggins@redhat.com